Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kopia/repository/config/aws.go: Set session.Options profile from config #6995

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

kaovilai
Copy link
Contributor

@kaovilai kaovilai commented Oct 20, 2023

Signed-off-by: Tiger Kaovilai tkaovila@redhat.com

Thank you for contributing to Velero!

Please add a summary of your change

non default s3 credential profiles work again after #6598

Does your change fix a particular issue?

Fixes #6996

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #6995 (d5f238c) into main (941dd00) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #6995   +/-   ##
=======================================
  Coverage   61.04%   61.05%           
=======================================
  Files         252      252           
  Lines       26854    26856    +2     
=======================================
+ Hits        16394    16396    +2     
  Misses       9305     9305           
  Partials     1155     1155           
Files Coverage Δ
pkg/repository/config/aws.go 50.00% <50.00%> (+1.85%) ⬆️

Lyndon-Li
Lyndon-Li previously approved these changes Oct 24, 2023
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@shubham-pampattiwar shubham-pampattiwar merged commit 03e582c into vmware-tanzu:main Oct 30, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non default s3 credential profiles do not work on Unified Repository Provider (kopia) - after #6598
4 participants